New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update OSTicket transport to use the from email address #5739 #5927

Merged
merged 1 commit into from Mar 3, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Feb 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Fixes: #5739
If this works and is accepted then we will need to send a notification out. Let me know when it's approved and I'll do that.

I've added a process_config include file so clean up the config we expect to see (I'm sure it's useable for other things). I did this rather than having a function that needed to be called as it's variables that should just be available.

@mention-bot

This comment has been minimized.

mention-bot commented Feb 16, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @tuxis-ie based on the history of these files to review this PR.

@laf laf referenced this pull request Feb 16, 2017

Closed

OS Ticket Transport API Broken #5739

2 of 5 tasks complete
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 16, 2017

The inspection completed: 1 updated code elements

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Feb 16, 2017

Auto-Deploy finished, Test PR at http://5927.ci.librenms.org or https://5927.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Feb 23, 2017

@laf

This comment has been minimized.

Member

laf commented Mar 1, 2017

bumpy bump bump bump @librenms/reviewers

@geordish geordish self-requested a review Mar 1, 2017

@geordish

I don't have an ability to test this. Reading the code it looks sensible however.

@laf laf merged commit 296360b into librenms:master Mar 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5739 branch Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment