fix: Limit get_graph_by_port_hostname() to one port and exclude deleted #5936

Merged
merged 1 commit into from Feb 17, 2017

Conversation

Projects
None yet
5 participants
@arjitc
Contributor

arjitc commented Feb 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 17, 2017

Thank you for submitting a PR @arjitc! We have found the following @murrant, @laf and @nerdalertdk based on the history of these files to review this PR.

Thank you for submitting a PR @arjitc! We have found the following @murrant, @laf and @nerdalertdk based on the history of these files to review this PR.

@arjitc

This comment has been minimized.

Show comment
Hide comment
@arjitc

arjitc Feb 17, 2017

Contributor

In my case, there were 3 ports being returned when polling 1 port, out of these 3 ports, 2 were deleted (same name but deleted) and 1 was the actual/current port graph. This patch pulls in only the non-deleted port.

Thanks to @laf for the help over IRC.

Contributor

arjitc commented Feb 17, 2017

In my case, there were 3 ports being returned when polling 1 port, out of these 3 ports, 2 were deleted (same name but deleted) and 1 was the actual/current port graph. This patch pulls in only the non-deleted port.

Thanks to @laf for the help over IRC.

@arjitc arjitc changed the title from Fixes issue with multiple ports returned for 1 port to fix: Limit get_graph_by_port_hostname() to one port and exclude deleted Feb 17, 2017

@laf laf added API Bug 🐞 labels Feb 17, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 17, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit debb945 into librenms:master Feb 17, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment