Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Added ability to output graphs as svg #5959

Merged
merged 4 commits into from Feb 22, 2017
Merged

feature: Added ability to output graphs as svg #5959

merged 4 commits into from Feb 22, 2017

Conversation

laf
Copy link
Member

@laf laf commented Feb 21, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added the WebUI label Feb 21, 2017
@mention-bot
Copy link

Thank you for submitting a PR @laf! We have found the following @murrant, @khobbits and @ekoyle based on the history of these files to review this PR.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5959.ci.librenms.org or https://5959.ci.librenms.org

murrant
murrant reviewed Feb 21, 2017
View reviewed changes
html/includes/graphs/graph.inc.php Outdated
@@ -102,6 +102,10 @@ function graph_error($string)
}
} else {
// $rrd_options .= " HRULE:0#999999";
if ($config['webui']['graph_type'] === 'svg') {
$rrd_options .= " --imgformat=SVG -m 0.75 -W 'librenms'";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add the librenms text at the bottom?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was just debug

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5959.ci.librenms.org or https://5959.ci.librenms.org

murrant
murrant approved these changes Feb 21, 2017
View reviewed changes
Copy link
Member

@murrant murrant left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It might be a good idea to suggest users of this use http2 or gzip.
nginx:

gzip on;
gzip_types image/svg+xml; #there should be more types here too

@laf
Copy link
Member Author

laf commented Feb 21, 2017

I'll try and get those docs together tomorrow.

@laf
Copy link
Member Author

laf commented Feb 22, 2017

All done

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5959.ci.librenms.org or https://5959.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: 1 updated code elements

@ghost
Copy link

ghost commented Feb 22, 2017

Thanks, look very nice on my 4K/5K displays.

@murrant murrant merged commit a869168 into librenms:master Feb 22, 2017
@laf laf deleted the svg-graphs branch February 22, 2017 12:09
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@murrant murrant murrant approved these changes

Assignees
No one assigned
Labels
WebUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@laf @mention-bot @LibreNMS-CI @scrutinizer-notifier @murrant