New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added ability to output graphs as svg #5959

Merged
merged 4 commits into from Feb 22, 2017

Conversation

Projects
None yet
6 participants
@laf
Member

laf commented Feb 21, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added the WebUI label Feb 21, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 21, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @khobbits and @ekoyle based on the history of these files to review this PR.

mention-bot commented Feb 21, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @khobbits and @ekoyle based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 21, 2017

Auto-Deploy finished, Test PR at http://5959.ci.librenms.org or https://5959.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 21, 2017

Auto-Deploy finished, Test PR at http://5959.ci.librenms.org or https://5959.ci.librenms.org

@murrant

murrant approved these changes Feb 21, 2017 edited

Looks good.

It might be a good idea to suggest users of this use http2 or gzip.
nginx:

gzip on;
gzip_types image/svg+xml; #there should be more types here too
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 21, 2017

Member

I'll try and get those docs together tomorrow.

Member

laf commented Feb 21, 2017

I'll try and get those docs together tomorrow.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 22, 2017

Member

All done

Member

laf commented Feb 22, 2017

All done

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 22, 2017

Auto-Deploy finished, Test PR at http://5959.ci.librenms.org or https://5959.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 22, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Feb 22, 2017

The inspection completed: 1 updated code elements

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Feb 22, 2017

Contributor

Thanks, look very nice on my 4K/5K displays.

Contributor

FTBZ commented Feb 22, 2017

Thanks, look very nice on my 4K/5K displays.

@murrant murrant merged commit a869168 into librenms:master Feb 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:svg-graphs branch Feb 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment