New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addhost.php throw proper exception when database add fails #5972

Merged
merged 2 commits into from Feb 22, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Feb 21, 2017

createHost() now throws an exception when adding to the database fails with a hint to run ./validate.php
Add phpdocs to createHost()

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: addhost.php throw proper exception when database add fails
createHost() now throws an exception when adding to the database fails with a hint to run ./validate.php
Add phpdocs to createHost()
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 21, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @zarya and @Rosiak based on the history of these files to review this PR.

Thank you for submitting a PR @murrant! We have found the following @laf, @zarya and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@laf laf merged commit 8d52812 into librenms:master Feb 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 22, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@murrant murrant deleted the murrant:addhost-update branch Feb 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment