New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add Smseagle transport support #5989

Merged
merged 5 commits into from Feb 24, 2017

Conversation

Projects
None yet
5 participants
@barryodonovan
Contributor

barryodonovan commented Feb 23, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Added support for SMSEagle hardware gateway (smseagle.eu) as alert transport.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 23, 2017

Thank you for submitting a PR @barryodonovan! We have found the following @laf, @murrant and @benwa based on the history of these files to review this PR.

mention-bot commented Feb 23, 2017

Thank you for submitting a PR @barryodonovan! We have found the following @laf, @murrant and @benwa based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 23, 2017

Auto-Deploy finished, Test PR at http://5989.ci.librenms.org or https://5989.ci.librenms.org

@laf laf changed the title from Smseagle to feature: Add Smseagle transport support Feb 23, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 23, 2017

Auto-Deploy finished, Test PR at http://5989.ci.librenms.org or https://5989.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 24, 2017

Member

Just realised that this is missing doc updates. Once that's done it's good for a merge.

Member

laf commented Feb 24, 2017

Just realised that this is missing doc updates. Once that's done it's good for a merge.

barryodonovan added some commits Feb 24, 2017

barryodonovan
Merge branch 'smseagle' of https://github.com/barryodonovan/librenms
…into smseagle

catching up on remote
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 24, 2017

Auto-Deploy finished, Test PR at http://5989.ci.librenms.org or https://5989.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 24, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Feb 24, 2017

The inspection completed: No new issues

@laf laf merged commit 0f663b3 into librenms:master Feb 24, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@barryodonovan barryodonovan deleted the barryodonovan:smseagle branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment