New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: fix device edit health update icons #5996

Merged
merged 1 commit into from Feb 25, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Feb 24, 2017

Allow 0 and "" for valid health update values.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

webui: fix device edit health update icons
Allow 0 and "" for valid health update values.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 24, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @benwa and @miken32 based on the history of these files to review this PR.

mention-bot commented Feb 24, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @benwa and @miken32 based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Feb 24, 2017

Auto-Deploy finished, Test PR at http://5996.ci.librenms.org or https://5996.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 24, 2017

Member

How come allow ""?

Member

laf commented Feb 24, 2017

How come allow ""?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Feb 25, 2017

Member

Many of my fields are empty, so I assume "" is perfectly fine. I can definitely change the code to not allow it. My main goal was to allow 0.

Member

murrant commented Feb 25, 2017

Many of my fields are empty, so I assume "" is perfectly fine. I can definitely change the code to not allow it. My main goal was to allow 0.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Feb 25, 2017

Member

We should probably fix why they are empty as well.

Member

laf commented Feb 25, 2017

We should probably fix why they are empty as well.

@laf laf merged commit 5637399 into librenms:master Feb 25, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:fix-health-update branch Feb 25, 2017

VVelox pushed a commit to VVelox/librenms that referenced this pull request Feb 28, 2017

webui: fix device edit health update icons (#5996)
Allow 0 and "" for valid health update values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment