Postfix #6002

Merged
merged 66 commits into from Mar 1, 2017

Conversation

Projects
None yet
6 participants
@VVelox
Contributor

VVelox commented Feb 25, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Adds detailed polling for Postfix.

This requires librenms/librenms-agent#92 .

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

VVelox and others added some commits Feb 15, 2017

kitsune
*rename it so it can be called via the apps page
*setup the apps page to call it
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 25, 2017

Thank you for submitting a PR @VVelox! We have found the following @murrant, @crcro and @sorano based on the history of these files to review this PR.

Thank you for submitting a PR @VVelox! We have found the following @murrant, @crcro and @sorano based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@@ -0,0 +1,37 @@
+<?php
+require 'includes/graphs/common.inc.php';

This comment has been minimized.

@laf

laf Feb 26, 2017

Member

Could you remove require 'includes/graphs/common.inc.php'; from each of the graph files and see if it's ok still. This is already included so doesn't need to be here.

@laf

laf Feb 26, 2017

Member

Could you remove require 'includes/graphs/common.inc.php'; from each of the graph files and see if it's ok still. This is already included so doesn't need to be here.

This comment has been minimized.

@VVelox

VVelox Feb 27, 2017

Contributor

Removed and it works well with out it.

@VVelox

VVelox Feb 27, 2017

Contributor

Removed and it works well with out it.

VVelox added some commits Feb 27, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Feb 27, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@laf laf merged commit 002f415 into librenms:master Mar 1, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@VVelox VVelox deleted the VVelox:Postfix branch Mar 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment