feature: Add Postgres application support #6004

Merged
merged 70 commits into from Mar 1, 2017

Conversation

Projects
None yet
6 participants
@VVelox
Contributor

VVelox commented Feb 25, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Adds support for polling Postgres.

This requires librenms/librenms-agent#91 .

VVelox and others added some commits Feb 15, 2017

kitsune
*rename it so it can be called via the apps page
*setup the apps page to call it
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 25, 2017

Thank you for submitting a PR @VVelox! We have found the following @murrant, @crcro and @sorano based on the history of these files to review this PR.

Thank you for submitting a PR @VVelox! We have found the following @murrant, @crcro and @sorano based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

VVelox added some commits Feb 27, 2017

@VVelox

This comment has been minimized.

Show comment
Hide comment
@VVelox

VVelox Feb 27, 2017

Contributor

Unneeded require lines in graphs removed and tested.

Contributor

VVelox commented Feb 27, 2017

Unneeded require lines in graphs removed and tested.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@laf laf changed the title from Postgres app add to feature: Add Postgres application support Mar 1, 2017

doc/Extensions/Applications.md
+
+6: Verify the path to check_postgres.pl in /etc/snmp/postgres is correct.
+
+7: If you wish it to ignore the database postres for totalling up the stats, set ignorePG to 1(the default) in /etc/snmp/postgres. If you are using netdata or the like, you may wish to set this or otherwise that total will be very skewed on systems with light or moderate usage.

This comment has been minimized.

@laf

laf Mar 1, 2017

Member

database postres - spelling mistake?

@laf

laf Mar 1, 2017

Member

database postres - spelling mistake?

This comment has been minimized.

@VVelox

VVelox Mar 1, 2017

Contributor

Yup. That it is.

@VVelox

VVelox Mar 1, 2017

Contributor

Yup. That it is.

+$postgres = snmp_walk($device, $oid, $options, $mib);
+
+list($backends, $commits, $rollbacks, $read, $hit, $idxscan, $idxtupread, $idxtupfetch, $idxblksread,
+ $idxblkshit, $seqscan, $seqtupread, $ret, $fetch, $ins, $upd, $del ) = explode("\n", $postgres);

This comment has been minimized.

@laf

laf Mar 1, 2017

Member

Extra space after $del

@laf

laf Mar 1, 2017

Member

Extra space after $del

@laf

Just two small changes and it's good to go

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 1, 2017

Member

Oh and a rebase.

Member

laf commented Mar 1, 2017

Oh and a rebase.

@VVelox

This comment has been minimized.

Show comment
Hide comment
@VVelox

VVelox Mar 1, 2017

Contributor

Changes made now. :)

Contributor

VVelox commented Mar 1, 2017

Changes made now. :)

doc/Extensions/Applications.md
@@ -539,7 +539,7 @@ extend postgres /etc/snmp/postgres
6: Verify the path to check_postgres.pl in /etc/snmp/postgres is correct.
-7: If you wish it to ignore the database postres for totalling up the stats, set ignorePG to 1(the default) in /etc/snmp/postgres. If you are using netdata or the like, you may wish to set this or otherwise that total will be very skewed on systems with light or moderate usage.
+7: If you wish it to ignore the database postges for totalling up the stats, set ignorePG to 1(the default) in /etc/snmp/postgres. If you are using netdata or the like, you may wish to set this or otherwise that total will be very skewed on systems with light or moderate usage.

This comment has been minimized.

@laf

laf Mar 1, 2017

Member

:) One spelling mistake to another :D

@laf

laf Mar 1, 2017

Member

:) One spelling mistake to another :D

This comment has been minimized.

@VVelox

VVelox Mar 1, 2017

Contributor

Hah! Was just about to reply with saying it is suppose to be lower case when I noticed the missing r.

@VVelox

VVelox Mar 1, 2017

Contributor

Hah! Was just about to reply with saying it is suppose to be lower case when I noticed the missing r.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 1, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf

laf approved these changes Mar 1, 2017

@laf laf merged commit de6b1d9 into librenms:master Mar 1, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@VVelox VVelox deleted the VVelox:Postgres branch Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment