New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added better BGP support for Arista #6046

Merged
merged 6 commits into from Mar 11, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Mar 1, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Tested against live Arista's which before used the cisco bgp but had limited info.

Tested against a Juniper EX4220 using snmpsim.

Will be rolling this out at work straight away so can check Cisco kit.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 1, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @Tristan-Labbe and @HenocKA based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @murrant, @Tristan-Labbe and @HenocKA based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 1, 2017

Member

Pretty sure this is all good now. Tested against cisco devices and made some tweaks.

I tidied up the discovery code, hopefully it's acceptable like that. I took a look a refactoring the poller code and lost the will to live :/

Member

laf commented Mar 1, 2017

Pretty sure this is all good now. Tested against cisco devices and made some tweaks.

I tidied up the discovery code, hopefully it's acceptable like that. I took a look a refactoring the poller code and lost the will to live :/

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 3, 2017

The inspection completed: 4 updated code elements

The inspection completed: 4 updated code elements

@laf

This comment has been minimized.

Show comment
Hide comment
Member

laf commented Mar 7, 2017

@murrant

Tested and works fine on my Cisco device with BGP.

@laf laf merged commit 38cebc5 into librenms:master Mar 11, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:arista-bgp branch Mar 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment