New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_disks function #6058

Merged
merged 4 commits into from Mar 3, 2017

Conversation

Projects
None yet
5 participants
@VVelox
Contributor

VVelox commented Mar 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Wrote this as I want to go write some smart stuff. As we don't want to glob the RRDs, this will allow for a lists of disks to manually be fetched.

Also this way if the SQL ever changes or the like, it is easier to update as it can be changed here instead of having to look ever where that may use it.

@mention-bot

This comment has been minimized.

mention-bot commented Mar 2, 2017

Thank you for submitting a PR @VVelox! We have found the following @murrant, @laf and @crcro based on the history of these files to review this PR.

@VVelox

This comment has been minimized.

Contributor

VVelox commented Mar 2, 2017

Wrote this as a run up to writing some SMART stuff.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 2, 2017

Auto-Deploy finished, Test PR at http://6058.ci.librenms.org or https://6058.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 2, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit 6844f29 into librenms:master Mar 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@VVelox VVelox deleted the VVelox:get_disks branch Mar 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment