New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ports in API requests for bills #6069

Merged
merged 2 commits into from Mar 3, 2017

Conversation

Projects
None yet
6 participants
@markhughes
Contributor

markhughes commented Mar 3, 2017

This is a simple addition to the API to expose the ports along with its device from the API when we call to view bills.

Example from output when calling to bills/1:

...
            "bill_notes": "",
            "bill_autoadded": "0",
            "ports_total": "1",
            "ports": [
                {
                    "device_id": "8",
                    "port_id": "263",
                    "ifName": "etc"
                }
            ],
            "allowed": "0.000B",
            "used": "10.000GB",
            "percent": "INF",
...

This allows us to then get graphs for bills. 🎉


DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

./scripts/pre-commit.php output:

➜  librenms git:(bills-api) ./scripts/pre-commit.php
Running unit tests... success
Running style check... success
Running lint check... success
Tests ok, submit away :)
  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 3, 2017

Thank you for submitting a PR @markehme! We have found the following @laf, @murrant and @nerdalertdk based on the history of these files to review this PR.

mention-bot commented Mar 3, 2017

Thank you for submitting a PR @markehme! We have found the following @laf, @murrant and @nerdalertdk based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 3, 2017

Auto-Deploy finished, Test PR at http://6069.ci.librenms.org or https://6069.ci.librenms.org

@markhughes

This comment has been minimized.

Show comment
Hide comment
@markhughes

markhughes Mar 3, 2017

Contributor

Amended to include ifName. See 8d0705a

Contributor

markhughes commented Mar 3, 2017

Amended to include ifName. See 8d0705a

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 3, 2017

Auto-Deploy finished, Test PR at http://6069.ci.librenms.org or https://6069.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 3, 2017

Auto-Deploy finished, Test PR at http://6069.ci.librenms.org or https://6069.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 3, 2017

The inspection completed: 2 new issues

scrutinizer-notifier commented Mar 3, 2017

The inspection completed: 2 new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 3, 2017

Member

I've updated the docs to show the new example.

Also fixed the query as it was using a hardcoded bill ID of 1.

Many thanks for contributing.

Member

laf commented Mar 3, 2017

I've updated the docs to show the new example.

Also fixed the query as it was using a hardcoded bill ID of 1.

Many thanks for contributing.

@laf laf merged commit dc41c0e into librenms:master Mar 3, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@markhughes markhughes deleted the markhughes:bills-api branch Mar 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment