New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the displaying of alert info for historical alerts #6092 #6107

Merged
merged 1 commit into from Mar 11, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Mar 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

The way alerts work is they register an alert_log entry for every device and every rule (not sure why). Because of this rules / devices that have never triggered will have blank details (now shows 'Rule created, no faults found') and rules which have previously triggered we look for the last alert where the state = 1 which means it was triggered and grabs the data we need from that.

Fixes: #6092

@laf laf added Bug 🐞 WebUI labels Mar 6, 2017

@mention-bot

This comment has been minimized.

mention-bot commented Mar 6, 2017

Thank you for submitting a PR @laf! We have found the following @benwa, @murrant and @f0o based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 6, 2017

Auto-Deploy finished, Test PR at http://6107.ci.librenms.org or https://6107.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 6, 2017

The inspection completed: No new issues

@djamp42

This comment has been minimized.

Contributor

djamp42 commented Mar 7, 2017

Just applied this, working perfectly fine for me! Thanks!

@laf laf merged commit fe130ea into librenms:master Mar 11, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-6092 branch Mar 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment