newdevice: Improve 3com switch detection #6114

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Mar 7, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes: #6104

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 7, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 7, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 7, 2017

Member

.1.3.6.1.4.1.43. showed no devices we shouldn't have as 3com OS on stats, but only .1.3.6.1.4.1.43.1. and .1.3.6.1.4.1.43.10. were present as well. Preference?

Member

murrant commented Mar 7, 2017

.1.3.6.1.4.1.43. showed no devices we shouldn't have as 3com OS on stats, but only .1.3.6.1.4.1.43.1. and .1.3.6.1.4.1.43.10. were present as well. Preference?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 7, 2017

Member

Why replace the test, seems valid data:

| 2|3com |.1.3.6.1.4.1.43.1.16.4.3.45 | 3Com Switch 4210 52-Port Software Version 3.10 Release 2215P12 |

Member

laf commented Mar 7, 2017

Why replace the test, seems valid data:

| 2|3com |.1.3.6.1.4.1.43.1.16.4.3.45 | 3Com Switch 4210 52-Port Software Version 3.10 Release 2215P12 |

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 7, 2017

Member

I thought we had enough data, no need for an extra test. I can add an extra test instead.

Member

murrant commented Mar 7, 2017

I thought we had enough data, no need for an extra test. I can add an extra test instead.

@laf laf merged commit 271413e into librenms:master Mar 7, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:3com branch Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment