New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change rfc1628 'state' (est. runtime and on battery) to runtime #6158

Merged
merged 4 commits into from Mar 12, 2017

Conversation

Projects
None yet
6 participants
@murrant
Member

murrant commented Mar 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

mention-bot commented Mar 10, 2017

Thank you for submitting a PR @murrant! We have found the following @laf and @einhirn based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 10, 2017

Auto-Deploy finished, Test PR at http://6158.ci.librenms.org or https://6158.ci.librenms.org

@FTBZ

This comment has been minimized.

Contributor

FTBZ commented Mar 10, 2017

Thanks for all your job @murrant. Not sure that these graphs are working enough in "runtime" type. Because when you're not on battery it returning nothing.

screen shot 2017-03-10 at 07 27 06

The "seconds on battery" graph a value of 0, but the "minutes remaining" graph isn't working (Error Drawing Graph).

@murrant

This comment has been minimized.

Member

murrant commented Mar 10, 2017

Yeah, not sure what the issue is with the graphs. I'l check it out when I get a chance.

Fix up the graph error ( : in ds name).
Change seconds on battery to minutes so the value is in minutes
@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 12, 2017

Auto-Deploy finished, Test PR at http://6158.ci.librenms.org or https://6158.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 12, 2017

Auto-Deploy finished, Test PR at http://6158.ci.librenms.org or https://6158.ci.librenms.org

@FTBZ FTBZ referenced this pull request Mar 12, 2017

Merged

fix: Adding state sensor support for RFC1628 UPS #6153

2 of 2 tasks complete
@laf

This comment has been minimized.

Member

laf commented Mar 12, 2017

I thought I'd commented on this last night, I updated #6153 before seeing this.

I can remove that change no problem but the runtime code should just be an snmp_get shouldn't it as it's only one OID.

@murrant

This comment has been minimized.

Member

murrant commented Mar 12, 2017

You commented on the application discovery PR, I was confused at first :-). Let me check the MIB, unless you already did...

@laf

This comment has been minimized.

Member

laf commented Mar 12, 2017

Was pushing my lack of sleep last night :/

image

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 12, 2017

Auto-Deploy finished, Test PR at http://6158.ci.librenms.org or https://6158.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 12, 2017

The inspection completed: No new issues

@laf laf merged commit 4ae4847 into librenms:master Mar 12, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:rfc-runtime branch Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment