poll and graph Rx levels on Ubiquiti Airfibre #6160

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
7 participants
@barryodonovan
Contributor

barryodonovan commented Mar 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Creating this due to messed up rebase on #5886

barryodonovan
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 10, 2017

Thank you for submitting a PR @barryodonovan! We have found the following @jquagga, @murrant and @laf based on the history of these files to review this PR.

Thank you for submitting a PR @barryodonovan! We have found the following @jquagga, @murrant and @laf based on the history of these files to review this PR.

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Mar 10, 2017

Contributor

@murrant
I've reapplied the diffs to a fresh branch

Contributor

barryodonovan commented Mar 10, 2017

@murrant
I've reapplied the diffs to a fresh branch

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
+
+$rrdfilename = rrd_name($device['hostname'], 'ubnt-airfibre-mib-rx');
+
+if (file_exists($rrdfilename)) {

This comment has been minimized.

@laf

laf Mar 11, 2017

Member

Needs to use rrdtool_check_rrd_exists as file_exists isn't rrdcached aware.

@laf

laf Mar 11, 2017

Member

Needs to use rrdtool_check_rrd_exists as file_exists isn't rrdcached aware.

@@ -1,6 +1,6 @@
os: airos-af
text: 'Ubiquiti AirFiber'
-type: network
+type: wireless

This comment has been minimized.

@laf

laf Mar 12, 2017

Member

This will need a notification to be sent out for this change. https://github.com/librenms/librenms.github.io/blob/master/notifications.rss - See the last commit and copy this. Do 4 days ahead of when you create the notifications.rss PR

@laf

laf Mar 12, 2017

Member

This will need a notification to be sent out for this change. https://github.com/librenms/librenms.github.io/blob/master/notifications.rss - See the last commit and copy this. Do 4 days ahead of when you create the notifications.rss PR

This comment has been minimized.

@barryodonovan

barryodonovan Mar 20, 2017

Contributor

@murrant merged the notification earlier, are we good on this to go?

@barryodonovan

barryodonovan Mar 20, 2017

Contributor

@murrant merged the notification earlier, are we good on this to go?

includes/polling/wifi.inc.php
@@ -9,6 +9,8 @@
} elseif ($device['os'] == 'airos-af') {
echo 'It Is AirFIBER' . PHP_EOL;
include 'includes/polling/mib/ubnt-airfiber-mib.inc.php';
+ echo 'It Is AirFIBER - Rx' . PHP_EOL;

This comment has been minimized.

@laf

laf Mar 12, 2017

Member

Is this a hangup from the last PR and can be removed?

@laf

laf Mar 12, 2017

Member

Is this a hangup from the last PR and can be removed?

@laf

Few changes needed imho

barryodonovan
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 13, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@blue-yu

This comment has been minimized.

Show comment
Hide comment
@blue-yu

blue-yu Mar 19, 2017

Stuck again?

blue-yu commented Mar 19, 2017

Stuck again?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 22, 2017

Member

@laf I think the time frame for merging this is tomorrow. Any changes needed?

Member

murrant commented Mar 22, 2017

@laf I think the time frame for merging this is tomorrow. Any changes needed?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 22, 2017

Member

@murrant correct. Nothing from me that's not already been addressed.

Member

laf commented Mar 22, 2017

@murrant correct. Nothing from me that's not already been addressed.

@laf laf merged commit 8404eef into librenms:master Mar 24, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@blue-yu

This comment has been minimized.

Show comment
Hide comment
@blue-yu

blue-yu Mar 26, 2017

AirFiber is in Wireless now, but still no RX Level! What should I do to get those values?

blue-yu commented Mar 26, 2017

AirFiber is in Wireless now, but still no RX Level! What should I do to get those values?

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Mar 27, 2017

Contributor
Contributor

barryodonovan commented Mar 27, 2017

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Mar 27, 2017

Contributor

@blue-yu I've submitted new PR with fix.

Contributor

barryodonovan commented Mar 27, 2017

@blue-yu I've submitted new PR with fix.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 27, 2017

Member

Merged, thanks both.

Member

laf commented Mar 27, 2017

Merged, thanks both.

@blue-yu

This comment has been minimized.

Show comment
Hide comment
@blue-yu

blue-yu Mar 27, 2017

Thanks a lot. It is working now. I can control RX Power. Yeahhhh.....

blue-yu commented Mar 27, 2017

Thanks a lot. It is working now. I can control RX Power. Yeahhhh.....

@blue-yu

This comment has been minimized.

Show comment
Hide comment
@blue-yu

blue-yu Apr 6, 2017

Hello again,

Graph is not displayed correctly. Can someone take a look at the issue?

blue-yu commented Apr 6, 2017

Hello again,

Graph is not displayed correctly. Can someone take a look at the issue?

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Apr 6, 2017

Contributor
Contributor

barryodonovan commented Apr 6, 2017

@blue-yu

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 6, 2017

Member

@barryodonovan might just be min/max values for the graphs.

Member

laf commented Apr 6, 2017

@barryodonovan might just be min/max values for the graphs.

@blue-yu

This comment has been minimized.

Show comment
Hide comment
@blue-yu

blue-yu Apr 6, 2017

It looks like that. Is that something that I can do it myself?

blue-yu commented Apr 6, 2017

It looks like that. Is that something that I can do it myself?

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Apr 7, 2017

Contributor
Contributor

barryodonovan commented Apr 7, 2017

@librenms librenms locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.