Added new alert rules to collection #6166

Merged
merged 4 commits into from Mar 15, 2017

Conversation

Projects
None yet
5 participants
@towster
Contributor

towster commented Mar 10, 2017

Added two new alert rules to the collection

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 10, 2017

Thank you for submitting a PR @towster! We have found the following @laf based on the history of these files to review this PR.

Thank you for submitting a PR @towster! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@@ -30,5 +30,13 @@
{
"rule": "%ports.ifOperStatus = \"down\" && %ports.ifOperStatus_prev = \"up\" && %macros.device_up = \"1\"",
"name": "Port status change from up to down"
+ },
+ {
+ "rule": "%ports.ifOutErrors_rate >= \"100\" || %ports.ifInErrors_rate >= \"100\"",

This comment has been minimized.

@laf

laf Mar 11, 2017

Member

Isn't this too specific, 100 error rate may not suite everyone.

@laf

laf Mar 11, 2017

Member

Isn't this too specific, 100 error rate may not suite everyone.

This comment has been minimized.

@towster

towster Mar 14, 2017

Contributor

It is true it may not but then I see these as more of examples of rules rather than absolutes. Before I had that rule I had no idea how to determine which ports were getting excessive errors.

@towster

towster Mar 14, 2017

Contributor

It is true it may not but then I see these as more of examples of rules rather than absolutes. Before I had that rule I had no idea how to determine which ports were getting excessive errors.

This comment has been minimized.

@laf

laf Mar 14, 2017

Member

Ok no worries. The only other issue with this is that || don't work well right now so it needs to be two rules or done as a macro

@laf

laf Mar 14, 2017

Member

Ok no worries. The only other issue with this is that || don't work well right now so it needs to be two rules or done as a macro

misc/alert_rules.json
+ "name": "Interface Errors Rate"
+ },
+ {
+ "rule": "%eventlog.type = \"discovery\" && %eventlog.message ~ \"autodiscovered\" && %eventlog.datetime >= %macros.past_60m",

This comment has been minimized.

@laf

laf Mar 11, 2017

Member

Should be: \"@autodiscovered@\"

The name should also be Device discovered within the last 60 minutes.

@laf

laf Mar 11, 2017

Member

Should be: \"@autodiscovered@\"

The name should also be Device discovered within the last 60 minutes.

towster added some commits Mar 14, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 14, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf removed the Blocker 🚫 label Mar 14, 2017

@laf laf merged commit fea705b into librenms:master Mar 15, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment