New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add APC NetBotz State Sensor Support #6167

Merged
merged 1 commit into from Mar 12, 2017

Conversation

Projects
None yet
5 participants
@Rosiak
Contributor

Rosiak commented Mar 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 10, 2017

Auto-Deploy finished, Test PR at http://6167.ci.librenms.org or https://6167.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Mar 10, 2017

The inspection completed: No new issues

if (is_array($temp)) {
//Create State Index
$state_name = 'otherStateSensorErrorStatus';

This comment has been minimized.

@murrant

murrant Mar 11, 2017

Member

This state name seems odd, is it meaningful?

@murrant

murrant Mar 11, 2017

Member

This state name seems odd, is it meaningful?

This comment has been minimized.

@laf

laf Mar 12, 2017

Member

It's not used anywhere and is referenced to the mib so seems appropriate if a little obscure.

@laf

laf Mar 12, 2017

Member

It's not used anywhere and is referenced to the mib so seems appropriate if a little obscure.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 11, 2017

Member

I've been thinking about state support a little, the state translations are basically static but if we do need to update them then it means schema files to do so.

Would it make more sense to add them into the os yaml file?

Member

laf commented Mar 11, 2017

I've been thinking about state support a little, the state translations are basically static but if we do need to update them then it means schema files to do so.

Would it make more sense to add them into the os yaml file?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 11, 2017

Member

@laf I was thinking of converting it to something similar to the RrdDefinition class.

Member

murrant commented Mar 11, 2017

@laf I was thinking of converting it to something similar to the RrdDefinition class.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 11, 2017

Member

I'm fine with either way, was just hoping for something a bit tidier in the sensors code. The state translations are static at the end of the day so we probably don't need them in the DB.

Member

laf commented Mar 11, 2017

I'm fine with either way, was just hoping for something a bit tidier in the sensors code. The state translations are static at the end of the day so we probably don't need them in the DB.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 12, 2017

Member

laf ah yes, I see what you mean.

Member

murrant commented Mar 12, 2017

laf ah yes, I see what you mean.

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Mar 12, 2017

Contributor

Interesting thought laf, I've been wanting to refactor the code for a while makes perfectly sense to me.

Contributor

Rosiak commented Mar 12, 2017

Interesting thought laf, I've been wanting to refactor the code for a while makes perfectly sense to me.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 12, 2017

Member

Actually, sod moving to yaml, definitely would be worse doing that.

Member

laf commented Mar 12, 2017

Actually, sod moving to yaml, definitely would be worse doing that.

@laf laf merged commit 745eb7b into librenms:master Mar 12, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rosiak Rosiak deleted the Rosiak:netbotz-state branch Nov 15, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.