fix: sensors not being removed from database #6169

Merged
merged 1 commit into from Mar 12, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Mar 11, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Sensor classes were incorrect and inconsistent. This makes them consistent and allows them to use the proper class name when removing from the database.

    fanspeeds => fanspeed
    frequencies => frequency
    states => state
    temperatures => temperature
    voltages => voltage
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 11, 2017

The inspection completed: 31 new issues

The inspection completed: 31 new issues

@laf laf merged commit 6993bd1 into librenms:master Mar 12, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:sensor-validity-fix branch Mar 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment