New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peeringdb integration to show the Exchanges and peers for your AS' #6178

Merged
merged 16 commits into from Mar 22, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Mar 12, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Bit rough around the edges, opening for testing rather than merging.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 12, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @benwa and @InsaneSplash based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @murrant, @benwa and @InsaneSplash based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 13, 2017

Member

If you've tested this before today then do the following in mysql:

drop table pdb_ix;
drop table pdb_ix_peers;
CREATE TABLE `pdb_ix` (  `pdb_ix_id` int(10) unsigned NOT NULL AUTO_INCREMENT,  `ix_id` int(10) unsigned NOT NULL,  `name` varchar(255) COLLATE utf8_unicode_ci NOT NULL,  `asn` int(10) unsigned NOT NULL,  `timestamp` int(10) unsigned NOT NULL,  PRIMARY KEY (`pdb_ix_id`)) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
CREATE TABLE `pdb_ix_peers` (  `pdb_ix_peers_id` int(10) unsigned NOT NULL AUTO_INCREMENT,  `ix_id` int(10) unsigned NOT NULL,  `peer_id` int(10) unsigned NOT NULL,  `remote_asn` varchar(16) COLLATE utf8_unicode_ci NOT NULL,  `name` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL,  `timestamp` int(10) unsigned DEFAULT NULL,  PRIMARY KEY (`pdb_ix_peers_id`)) ENGINE=InnoDB  DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
``
Member

laf commented Mar 13, 2017

If you've tested this before today then do the following in mysql:

drop table pdb_ix;
drop table pdb_ix_peers;
CREATE TABLE `pdb_ix` (  `pdb_ix_id` int(10) unsigned NOT NULL AUTO_INCREMENT,  `ix_id` int(10) unsigned NOT NULL,  `name` varchar(255) COLLATE utf8_unicode_ci NOT NULL,  `asn` int(10) unsigned NOT NULL,  `timestamp` int(10) unsigned NOT NULL,  PRIMARY KEY (`pdb_ix_id`)) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
CREATE TABLE `pdb_ix_peers` (  `pdb_ix_peers_id` int(10) unsigned NOT NULL AUTO_INCREMENT,  `ix_id` int(10) unsigned NOT NULL,  `peer_id` int(10) unsigned NOT NULL,  `remote_asn` varchar(16) COLLATE utf8_unicode_ci NOT NULL,  `name` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL,  `timestamp` int(10) unsigned DEFAULT NULL,  PRIMARY KEY (`pdb_ix_peers_id`)) ENGINE=InnoDB  DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
``
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 13, 2017

Member

Needs docs on this btw so don't merge just yet.

Member

laf commented Mar 13, 2017

Needs docs on this btw so don't merge just yet.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 14, 2017

Member

Pushing another update, if you've tested today please run:

ALTER TABLE `pdb_ix_peers` ADD `remote_ipaddr4` VARCHAR(15) NULL AFTER `remote_asn`, ADD `remote_ipaddr6` VARCHAR(128) NULL AFTER `remote_ipadd4`;
Member

laf commented Mar 14, 2017

Pushing another update, if you've tested today please run:

ALTER TABLE `pdb_ix_peers` ADD `remote_ipaddr4` VARCHAR(15) NULL AFTER `remote_asn`, ADD `remote_ipaddr6` VARCHAR(128) NULL AFTER `remote_ipadd4`;
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 14, 2017

Member

If you've tested this PR then please run this in mysql:

INSERT INTO config (config_name,config_value,config_default,config_descr,config_group,config_group_order,config_sub_group,config_sub_group_order,config_hidden,config_disabled) values ('alert.default_if_none','false','false','Send mail to default contact if no other contacts are found','alerting',0,'general',0,'0','0');
Member

laf commented Mar 14, 2017

If you've tested this PR then please run this in mysql:

INSERT INTO config (config_name,config_value,config_default,config_descr,config_group,config_group_order,config_sub_group,config_sub_group_order,config_hidden,config_disabled) values ('alert.default_if_none','false','false','Send mail to default contact if no other contacts are found','alerting',0,'general',0,'0','0');
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 22, 2017

The inspection completed: 663 Issues, 19 Patches

The inspection completed: 663 Issues, 19 Patches

@laf laf merged commit 5f5dc2a into librenms:master Mar 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:peeringdb branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment