add SMART app support #6181

Merged
merged 7 commits into from Mar 22, 2017

Conversation

Projects
None yet
6 participants
@VVelox
Contributor

VVelox commented Mar 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Replaces #6128 as that one ate it's self in a rebase.

Depends on librenms/librenms-agent#101 .

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 13, 2017

Thank you for submitting a PR @VVelox! We have found the following @murrant, @crcro and @karlshea based on the history of these files to review this PR.

Thank you for submitting a PR @VVelox! We have found the following @murrant, @crcro and @karlshea based on the history of these files to review this PR.

@VVelox VVelox referenced this pull request Mar 13, 2017

Closed

add SMART support #6128

2 of 2 tasks complete
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 13, 2017

The inspection completed: 1 new issues, 1 updated code elements

The inspection completed: 1 new issues, 1 updated code elements

@laf laf referenced this pull request Mar 15, 2017

Closed

HDD SMART data #1161

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 15, 2017

Member

I've put a mention up on community and an old issue here to test this.

Member

laf commented Mar 15, 2017

I've put a mention up on community and an old issue here to test this.

@sorano

This comment has been minimized.

Show comment
Hide comment
@sorano

sorano Mar 20, 2017

Contributor

I tested this last week and after some fixes in the script from VVelox it worked.

Contributor

sorano commented Mar 20, 2017

I tested this last week and after some fixes in the script from VVelox it worked.

@laf laf merged commit 0a4b265 into librenms:master Mar 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment