graphs $auth bool check was too strict #6195

Merged
merged 2 commits into from Mar 14, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Mar 14, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

For some reason the recent change to port_permitted() means the === true check now fails. I've changed this to be loose.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 14, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @paulgear and @tuxis-ie based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @murrant, @paulgear and @tuxis-ie based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 14, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@murrant murrant merged commit c2ce20e into librenms:master Mar 14, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:graph-strict-check branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment