New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Send collected data to graphite server #6201

Merged
merged 14 commits into from Mar 22, 2017

Conversation

Projects
None yet
7 participants
@fstern
Contributor

fstern commented Mar 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This sends all collected data to a remote graphite server.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 15, 2017

Thank you for submitting a PR @fstern! We have found the following @laf, @murrant and @BarbarossaTM based on the history of these files to review this PR.

Thank you for submitting a PR @fstern! We have found the following @laf, @murrant and @BarbarossaTM based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated poller.php
$graphite_port = $config['graphite']['port'];
} else {
$graphite_port = '2003';
}

This comment has been minimized.

@geordish

geordish Mar 15, 2017

Contributor

Set the default in includes/defaults.inc.php. This entire isset piece is then not needed.

@geordish

geordish Mar 15, 2017

Contributor

Set the default in includes/defaults.inc.php. This entire isset piece is then not needed.

This comment has been minimized.

@fstern

fstern Mar 15, 2017

Contributor

Thanks, I've moved it to includes/defaults.inc.php

@fstern

fstern Mar 15, 2017

Contributor

Thanks, I've moved it to includes/defaults.inc.php

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 15, 2017

Member

I've put a shout out for testers: https://t.libren.ms/352vd

Member

laf commented Mar 15, 2017

I've put a shout out for testers: https://t.libren.ms/352vd

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@murrant murrant changed the title from Send collected data to graphite server to feature: Send collected data to graphite server Mar 20, 2017

@laf

laf approved these changes Mar 22, 2017

laf added some commits Mar 22, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 22, 2017

The inspection completed: 664 Issues, 19 Patches

The inspection completed: 664 Issues, 19 Patches

@murrant murrant merged commit affe509 into librenms:master Mar 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fstern fstern deleted the fstern:send_data_to_graphite branch Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment