New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alerts that worsen or get better will now record updated info #4323 #6203

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
2 participants
@laf
Member

laf commented Mar 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #4323

Simple one this, even though an alert doesn't change state it could have got worse or better so we need to record those changes.

@mention-bot

This comment has been minimized.

mention-bot commented Mar 15, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @f0o and @FTBZ based on the history of these files to review this PR.

@laf laf merged commit a752dc1 into librenms:master Mar 22, 2017

1 of 2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-4323 branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment