refactor: Move some DNOS detection to PowerConnect #6150 #6206

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Mar 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Will need to send out a notification of change so don't merge, just need confirmation this is ok to put a date in for merging.

Moves dnos v6 (powerconnect based) OS to powerconnect as they should be.

Fixes: #6150

Will be merged on the 24th.

This will change dnos v6 to powerconnect which is in line with the actual OS running.

@laf laf added the Device 🖥 label Mar 15, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 15, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 16, 2017

Member

Looks good any consideration for making the display name something like Powerconnect / DNOS6?

Member

murrant commented Mar 16, 2017

Looks good any consideration for making the display name something like Powerconnect / DNOS6?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 16, 2017

Member

Not from me :)

Member

laf commented Mar 16, 2017

Not from me :)

@murrant

Looks good and makes a lot of sense to me.

@laf laf merged commit 3da412d into librenms:master Mar 24, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-6150-2 branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment