New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update BIND support #6218

Merged
merged 16 commits into from May 3, 2017

Conversation

Projects
None yet
6 participants
@VVelox
Contributor

VVelox commented Mar 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This requires librenms/librenms-agent#108 .

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 17, 2017

Thank you for submitting a PR @VVelox! We have found the following @f0o, @murrant and @laf based on the history of these files to review this PR.

mention-bot commented Mar 17, 2017

Thank you for submitting a PR @VVelox! We have found the following @f0o, @murrant and @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 17, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

VVelox added some commits Mar 17, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 17, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 17, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 21, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 22, 2017

Member

Is this a breaking change to existing setups?

Member

laf commented Mar 22, 2017

Is this a breaking change to existing setups?

@VVelox

This comment has been minimized.

Show comment
Hide comment
@VVelox

VVelox Mar 22, 2017

Contributor

Datawise no, but from a polling standpoint yes. Requires that updated as the existing poller won't feed it useful data.

Regardless though the poller stuff for this needed a massive rewrite as it was just truly awful. It transfers the entire stat file over the wire and assumes that it is the only thing using the stat file.

Contributor

VVelox commented Mar 22, 2017

Datawise no, but from a polling standpoint yes. Requires that updated as the existing poller won't feed it useful data.

Regardless though the poller stuff for this needed a massive rewrite as it was just truly awful. It transfers the entire stat file over the wire and assumes that it is the only thing using the stat file.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 26, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 26, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

@f0o

One comment,

Instead of fully removing the copyright note, you should just add your own.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 5, 2017

Member

If the unix-agent code hasn't changed then surely this should remain backwards compatible?

Member

laf commented Apr 5, 2017

If the unix-agent code hasn't changed then surely this should remain backwards compatible?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 24, 2017

Member

@VVelox Any further updates on this?

Member

laf commented Apr 24, 2017

@VVelox Any further updates on this?

VVelox added some commits Apr 30, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 30, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

@VVelox

This comment has been minimized.

Show comment
Hide comment
@VVelox

VVelox Apr 30, 2017

Contributor

@f0o Whoops. Sorry, good catch about that bit. Readded for html/pages/device/apps/bind.inc.php .

Updated. Should be all good now.

Contributor

VVelox commented Apr 30, 2017

@f0o Whoops. Sorry, good catch about that bit. Readded for html/pages/device/apps/bind.inc.php .

Updated. Should be all good now.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 30, 2017

Auto-Deploy finished, Test PR at http://6218.ci.librenms.org or https://6218.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 30, 2017

The inspection completed: 654 Issues, 20 Patches

scrutinizer-notifier commented Apr 30, 2017

The inspection completed: 654 Issues, 20 Patches

@laf

laf approved these changes May 1, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 1, 2017

Member

@librenms/reviewers tagging to be merged in 48 hours

Member

laf commented May 1, 2017

@librenms/reviewers tagging to be merged in 48 hours

@laf laf merged commit 62a562b into librenms:master May 3, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.