Basic discovery of Cyclades ACS 6000 #6234

Merged
merged 7 commits into from Mar 22, 2017

Conversation

Projects
None yet
6 participants
@KlaasT
Contributor

KlaasT commented Mar 22, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 22, 2017

Thank you for submitting a PR @KlaasT! We have found the following @laf based on the history of these files to review this PR.

Thank you for submitting a PR @KlaasT! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 22, 2017

Member

Thanks for this, you will need to fix the conflict in AUTHORS.md.

Can you also add unit test for this: http://docs.librenms.org/Developing/Support-New-OS/#os-test-units

Member

laf commented Mar 22, 2017

Thanks for this, you will need to fix the conflict in AUTHORS.md.

Can you also add unit test for this: http://docs.librenms.org/Developing/Support-New-OS/#os-test-units

@KlaasT

This comment has been minimized.

Show comment
Hide comment
@KlaasT

KlaasT Mar 22, 2017

Contributor

I'll try my very best :-)

Contributor

KlaasT commented Mar 22, 2017

I'll try my very best :-)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 22, 2017

Member

It's easy :D

Member

laf commented Mar 22, 2017

It's easy :D

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@KlaasT

This comment has been minimized.

Show comment
Hide comment
@KlaasT

KlaasT Mar 22, 2017

Contributor

I hope these work. Forgive me if I still have to correct something. This is my first work on LibreNMS :-)

Contributor

KlaasT commented Mar 22, 2017

I hope these work. Forgive me if I still have to correct something. This is my first work on LibreNMS :-)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@KlaasT

This comment has been minimized.

Show comment
Hide comment
@KlaasT

KlaasT Mar 22, 2017

Owner

Ah OK. Thanks for the correction.

Owner

KlaasT commented on 66db233 Mar 22, 2017

Ah OK. Thanks for the correction.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 22, 2017

Member

Thanks for contributing :)

I have updated this to use sysObjectId instead of sysObjectDescr as we prefer that where possible.

Member

laf commented Mar 22, 2017

Thanks for contributing :)

I have updated this to use sysObjectId instead of sysObjectDescr as we prefer that where possible.

@laf laf added the Device 🖥 label Mar 22, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 22, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit 374f6b3 into librenms:master Mar 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment