Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic discovery of Cyclades ACS 6000 #6234

Merged
merged 7 commits into from Mar 22, 2017

Conversation

Projects
None yet
6 participants
@KlaasT
Copy link
Contributor

KlaasT commented Mar 22, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Mar 22, 2017

Thank you for submitting a PR @KlaasT! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Mar 22, 2017

Auto-Deploy finished, Test PR at http://6234.ci.librenms.org or https://6234.ci.librenms.org

@laf

This comment has been minimized.

Copy link
Member

laf commented Mar 22, 2017

Thanks for this, you will need to fix the conflict in AUTHORS.md.

Can you also add unit test for this: http://docs.librenms.org/Developing/Support-New-OS/#os-test-units

@KlaasT

This comment has been minimized.

Copy link
Contributor Author

KlaasT commented Mar 22, 2017

I'll try my very best :-)

@laf

This comment has been minimized.

Copy link
Member

laf commented Mar 22, 2017

It's easy :D

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Mar 22, 2017

Auto-Deploy finished, Test PR at http://6234.ci.librenms.org or https://6234.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Mar 22, 2017

Auto-Deploy finished, Test PR at http://6234.ci.librenms.org or https://6234.ci.librenms.org

@KlaasT

This comment has been minimized.

Copy link
Contributor Author

KlaasT commented Mar 22, 2017

I hope these work. Forgive me if I still have to correct something. This is my first work on LibreNMS :-)

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Mar 22, 2017

Auto-Deploy finished, Test PR at http://6234.ci.librenms.org or https://6234.ci.librenms.org

@KlaasT

This comment has been minimized.

Copy link
Owner

KlaasT commented on 66db233 Mar 22, 2017

Ah OK. Thanks for the correction.

@laf

This comment has been minimized.

Copy link
Member

laf commented Mar 22, 2017

Thanks for contributing :)

I have updated this to use sysObjectId instead of sysObjectDescr as we prefer that where possible.

@laf laf added the Device 🖥 label Mar 22, 2017

@LibreNMS-CI

This comment has been minimized.

Copy link

LibreNMS-CI commented Mar 22, 2017

Auto-Deploy finished, Test PR at http://6234.ci.librenms.org or https://6234.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Mar 22, 2017

The inspection completed: No new issues

@laf laf merged commit 374f6b3 into librenms:master Mar 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.