frequency can be < 0 #6240

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
5 participants
@tsumaru720
Contributor

tsumaru720 commented Mar 22, 2017

Frequency can be a negative value - having the scale limited to 0 makes the graphs not render properly if all values in RRD are negative (Also displays incorrectly if it flip/flops between positive/negative)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 22, 2017

Thank you for submitting a PR @tsumaru720! We have found the following @crcro, @VVelox and @murrant based on the history of these files to review this PR.

Thank you for submitting a PR @tsumaru720! We have found the following @crcro, @VVelox and @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 22, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit d8d0bb3 into librenms:master Mar 22, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tsumaru720 tsumaru720 deleted the tsumaru720:freq-fix branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment