New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Support for Netscaler SDX appliances #6249

Merged
merged 4 commits into from Mar 23, 2017

Conversation

Projects
None yet
5 participants
@KlaasT
Contributor

KlaasT commented Mar 23, 2017

This one is for discovering Netscaler SDX appliances. Including the missing MIBs for Netscaler.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

mention-bot commented Mar 23, 2017

Thank you for submitting a PR @KlaasT! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 23, 2017

Auto-Deploy finished, Test PR at http://6249.ci.librenms.org or https://6249.ci.librenms.org

@@ -0,0 +1 @@
1.3.6.1.2.1.1.2.0|6|1.3.6.1.4.1.5951.6

This comment has been minimized.

@laf

laf Mar 23, 2017

Member

This also needs the sysDescr value:

1.3.6.1.2.1.1.1.0|4|Somedescription

This comment has been minimized.

@KlaasT

KlaasT Mar 23, 2017

Contributor

Can the description be obfuscated in some parts? If I take the complete description string it would contain internal hostnames.

Edit: I mean is it allowed to shorten the String.

This comment has been minimized.

@laf

laf Mar 23, 2017

Member

Absolutely, just don't chop it down, i.e replace domain.com with example.com - don't remove it.

This comment has been minimized.

@KlaasT

KlaasT Mar 23, 2017

Contributor

Ok. Done. The real hostname didn't even have a domain in the snmpwalk. I've just replaced it with "examplehost".

This comment has been minimized.

@laf

laf Mar 23, 2017

Member

Does that not still have your domain in it?

This comment has been minimized.

@KlaasT

KlaasT Mar 23, 2017

Contributor

I've searched for that strange hostname and found it in some support cases. I think it is just the host where the SDX software has been compiled on.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 23, 2017

Auto-Deploy finished, Test PR at http://6249.ci.librenms.org or https://6249.ci.librenms.org

@laf

This comment has been minimized.

Member

laf commented Mar 23, 2017

Only small change was to add mib_dir to use the citrix folder otherwise they wouldn't be used when more code was written to try and extract data from them

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Mar 23, 2017

Auto-Deploy finished, Test PR at http://6249.ci.librenms.org or https://6249.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 23, 2017

The inspection completed: No new issues

@laf laf merged commit 7146d17 into librenms:master Mar 23, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment