New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Do not show disabled devices in alerts list as they stale #6213 #6263

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
6 participants
@laf
Member

laf commented Mar 23, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6213

I've not provided an option to show hidden alerts, we might get asked for that but it adds unnecessary complicates.

@laf laf added the WebUI label Mar 23, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 23, 2017

Thank you for submitting a PR @laf! We have found the following @ekoyle, @murrant and @benwa based on the history of these files to review this PR.

mention-bot commented Mar 23, 2017

Thank you for submitting a PR @laf! We have found the following @ekoyle, @murrant and @benwa based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 23, 2017

Auto-Deploy finished, Test PR at http://6263.ci.librenms.org or https://6263.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 23, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Mar 23, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 23, 2017

Member

Alerts are still visible at the device level, or this affects both?

Member

murrant commented Mar 23, 2017

Alerts are still visible at the device level, or this affects both?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 23, 2017

Member

Both, I can add it back to the device page itself but the initial issue would still be valid for that page.

Member

laf commented Mar 23, 2017

Both, I can add it back to the device page itself but the initial issue would still be valid for that page.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 24, 2017

Member

I would think it would be expected to see all device alerts on the device page even when it is disabled.

Member

murrant commented Mar 24, 2017

I would think it would be expected to see all device alerts on the device page even when it is disabled.

@ekoyle

This comment has been minimized.

Show comment
Hide comment
@ekoyle

ekoyle Mar 24, 2017

Contributor
Contributor

ekoyle commented Mar 24, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 24, 2017

Member

I'm actually of the opinion we shouldn't show these on the device page as they aren't alerts. The alternative is to change the status box for the alert to 'disabled'

Member

laf commented Mar 24, 2017

I'm actually of the opinion we shouldn't show these on the device page as they aren't alerts. The alternative is to change the status box for the alert to 'disabled'

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 24, 2017

Member

Sounds good to me. Just wanted to discus it a bit.

Member

murrant commented Mar 24, 2017

Sounds good to me. Just wanted to discus it a bit.

@murrant murrant merged commit 04beee6 into librenms:master Mar 24, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-6213 branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment