New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update applications poller to use numeric oid instead of nsExtendOutputFull #6277

Merged
merged 3 commits into from Mar 31, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Mar 26, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #5197

Seen a few issues now where nsExtendOutputFull doesn't work but the OID does. I don't know why so switched the applications around to use numerical oid.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 26, 2017

Thank you for submitting a PR @laf! We have found the following @VVelox based on the history of these files to review this PR.

mention-bot commented Mar 26, 2017

Thank you for submitting a PR @laf! We have found the following @VVelox based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 26, 2017

Auto-Deploy finished, Test PR at http://6277.ci.librenms.org or https://6277.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 27, 2017

Member

@laf Seems ok, but could use a little extra cleanup.

nsExtendOutLine.* = each line at a different oid
nsExtendOutputFull = all lines at one OID

If you change all of them to nsExtendOutputFull ".1.3.6.1.4.1.8072.1.3.2.3.1.2", then it should just be snmp_get(), not snmp_walk().

Member

murrant commented Mar 27, 2017

@laf Seems ok, but could use a little extra cleanup.

nsExtendOutLine.* = each line at a different oid
nsExtendOutputFull = all lines at one OID

If you change all of them to nsExtendOutputFull ".1.3.6.1.4.1.8072.1.3.2.3.1.2", then it should just be snmp_get(), not snmp_walk().

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 27, 2017

Member

Sorry I'm not sure what you mean by the comment in the code block.

As for _get instead of _walk, this change shouldn't alter us looking up a table, the lookup is the same as before but we aren't using the named oid.

Member

laf commented Mar 27, 2017

Sorry I'm not sure what you mean by the comment in the code block.

As for _get instead of _walk, this change shouldn't alter us looking up a table, the lookup is the same as before but we aren't using the named oid.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 27, 2017

Member

I'm saying there is confusion of nsExtendOutputFull and nsExtendOutLine all over the applications.

You've replaced them all with nsExtendOutputFull (numeric). Which is a single OID so all of the SNMP calls should just be snmp_get.

Member

murrant commented Mar 27, 2017

I'm saying there is confusion of nsExtendOutputFull and nsExtendOutLine all over the applications.

You've replaced them all with nsExtendOutputFull (numeric). Which is a single OID so all of the SNMP calls should just be snmp_get.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 28, 2017

Member

Ok updated. I have left the walks though, there's a mix of walks and gets and I don't want to break things.

Member

laf commented Mar 28, 2017

Ok updated. I have left the walks though, there's a mix of walks and gets and I don't want to break things.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 28, 2017

Auto-Deploy finished, Test PR at http://6277.ci.librenms.org or https://6277.ci.librenms.org

librenms
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 30, 2017

Member

Rebased

Member

laf commented Mar 30, 2017

Rebased

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 30, 2017

Auto-Deploy finished, Test PR at http://6277.ci.librenms.org or https://6277.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 31, 2017

Auto-Deploy finished, Test PR at http://6277.ci.librenms.org or https://6277.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 31, 2017

The inspection completed: 7 new issues

scrutinizer-notifier commented Mar 31, 2017

The inspection completed: 7 new issues

@murrant murrant merged commit a6391ed into librenms:master Mar 31, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Mar 31, 2017

Member

Odd that this is needed. But no issues with it.

Member

murrant commented Mar 31, 2017

Odd that this is needed. But no issues with it.

@laf laf deleted the laf:issue-5197 branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment