New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height of widget boxes #6282

Merged
merged 2 commits into from Mar 28, 2017

Conversation

Projects
None yet
5 participants
@jplitza
Contributor

jplitza commented Mar 27, 2017

This fixes overflowing scrollable widgets (see screenshot) without breaking the intention of #5644

overflow screenshot

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

jplitza added some commits Mar 27, 2017

Fix height of widget boxes
This pracitcally reverts #5644 and instead applies the correct fix by
calculating the dimensions of the widget box correctly.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 27, 2017

Thank you for submitting a PR @jplitza! We have found the following @paulgear, @laf and @f0o based on the history of these files to review this PR.

mention-bot commented Mar 27, 2017

Thank you for submitting a PR @jplitza! We have found the following @paulgear, @laf and @f0o based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Mar 27, 2017

Auto-Deploy finished, Test PR at http://6282.ci.librenms.org or https://6282.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 27, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Mar 27, 2017

The inspection completed: No new issues

@laf laf merged commit 323df86 into librenms:master Mar 28, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 28, 2017

Member

Thanks for contributing :)

Member

laf commented Mar 28, 2017

Thanks for contributing :)

f0o added a commit to f0o/librenms that referenced this pull request Apr 5, 2017

laf added a commit that referenced this pull request Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment