New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add semicolons in sql scripts #6284

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Projects
None yet
5 participants
@jarischaefer
Contributor

jarischaefer commented Mar 27, 2017

Adds missing semicolons in SQL scripts.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 27, 2017

Thank you for submitting a PR @jarischaefer! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented Mar 27, 2017

Thank you for submitting a PR @jarischaefer! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Mar 27, 2017

Auto-Deploy finished, Test PR at http://6284.ci.librenms.org or https://6284.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 27, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Mar 27, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 28, 2017

Member

Thanks, good to tidy these up but they aren't strictly needed unless you directly import them into mysql.

Member

laf commented Mar 28, 2017

Thanks, good to tidy these up but they aren't strictly needed unless you directly import them into mysql.

@laf laf merged commit dc01b8b into librenms:master Mar 28, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jarischaefer

This comment has been minimized.

Show comment
Hide comment
@jarischaefer

jarischaefer Mar 28, 2017

Contributor

After I had encountered errors running the build-base script, I tried importing the SQLs manually via MySQL's CLI, which resulted in the errors fixed by this PR.

It seems the build-base script ignores all SQL errors and just keeps going with no visible error messages.

I will probably submit another PR shortly, which fixes some of the "real" errors that forced me to use the CLI directly in the first place.

Contributor

jarischaefer commented Mar 28, 2017

After I had encountered errors running the build-base script, I tried importing the SQLs manually via MySQL's CLI, which resulted in the errors fixed by this PR.

It seems the build-base script ignores all SQL errors and just keeps going with no visible error messages.

I will probably submit another PR shortly, which fixes some of the "real" errors that forced me to use the CLI directly in the first place.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 28, 2017

Member

@jarischaefer Running build base gives you an error count (we have unit tests against these - slightly broken right now). I've recently been through and fixed all the errors, please ensure you don't have mysql strict mode enabled.

Member

laf commented Mar 28, 2017

@jarischaefer Running build base gives you an error count (we have unit tests against these - slightly broken right now). I've recently been through and fixed all the errors, please ensure you don't have mysql strict mode enabled.

@jarischaefer

This comment has been minimized.

Show comment
Hide comment
@jarischaefer

jarischaefer Mar 28, 2017

Contributor

I just tested everything with the official MySQL docker image. MySQL 5.7 does not work at all (they removed ALTER IGNORE TABLE in 5.7.4, which breaks 109.sql) and 5.6 still fails at #6289.

Contributor

jarischaefer commented Mar 28, 2017

I just tested everything with the official MySQL docker image. MySQL 5.7 does not work at all (they removed ALTER IGNORE TABLE in 5.7.4, which breaks 109.sql) and 5.6 still fails at #6289.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment