New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move user preferences dashboard and twofactor out of users table #6286

Merged
merged 6 commits into from Apr 1, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Mar 28, 2017

This allows them to work with any authentication method
Add set_user_pref() and get_user_pref() helper functions

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes: #5094, #3376

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 28, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o, @laf and @arjitc based on the history of these files to review this PR.

mention-bot commented Mar 28, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o, @laf and @arjitc based on the history of these files to review this PR.

fix: move user preferences dashboard and twofactor out of users table
This allows them to work with any authentication method
Add set_user_pref() and get_user_pref() helper functions
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 28, 2017

Auto-Deploy finished, Test PR at http://6286.ci.librenms.org or https://6286.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 28, 2017

Auto-Deploy finished, Test PR at http://6286.ci.librenms.org or https://6286.ci.librenms.org

@murrant murrant referenced this pull request Mar 28, 2017

Merged

feature: bind user for active_directory auth #6255

2 of 2 tasks complete
Show outdated Hide outdated sql-schema/183.sql
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 28, 2017

Auto-Deploy finished, Test PR at http://6286.ci.librenms.org or https://6286.ci.librenms.org

Show outdated Hide outdated sql-schema/183.sql
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 31, 2017

Auto-Deploy finished, Test PR at http://6286.ci.librenms.org or https://6286.ci.librenms.org

librenms
@laf

laf approved these changes Mar 31, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 31, 2017

Auto-Deploy finished, Test PR at http://6286.ci.librenms.org or https://6286.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 31, 2017

The inspection completed: 3 updated code elements

scrutinizer-notifier commented Mar 31, 2017

The inspection completed: 3 updated code elements

@laf laf merged commit 4b9f3f3 into librenms:master Apr 1, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:fix-user-prefs branch Apr 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment