New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Add support for AvediaStream Encoder #6306

Merged
merged 3 commits into from Mar 31, 2017

Conversation

Projects
None yet
4 participants
@FTBZ
Contributor

FTBZ commented Mar 30, 2017

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


  • Add support for AvediaStream Encoder
  • Detected as generic Linux, can't use the sysObjectId only, because is a Linux standard
  • OS name returned by SNMP is Ardmore Encoder VX
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 30, 2017

Member

This is missing unit tests: http://docs.librenms.org/Developing/Support-New-OS/#os-test-units

  • 1 Commet I left about sysDescr.
Member

laf commented Mar 30, 2017

This is missing unit tests: http://docs.librenms.org/Developing/Support-New-OS/#os-test-units

  • 1 Commet I left about sysDescr.

@laf laf added the Device 🖥 label Mar 30, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated includes/definitions/ardmore-encoder.yaml
- { graph: device_bits, text: Traffic }
discovery:
- sysDescr_regex:
- '/^Ardmore-Encoder_VX/'

This comment has been minimized.

@laf

laf Mar 31, 2017

Member

Can we not just use sysObjectId? sysDescr is not a preferred choice.

@laf

laf Mar 31, 2017

Member

Can we not just use sysObjectId? sysDescr is not a preferred choice.

Show outdated Hide outdated tests/OSDiscoveryTest.php
@@ -206,6 +206,11 @@ public function testApic()
{
$this->checkOS('apic');
}
public function testArdmore-encoder()

This comment has been minimized.

@laf

laf Mar 31, 2017

Member

Change to: public function testArdmoreEncoder()

@laf

laf Mar 31, 2017

Member

Change to: public function testArdmoreEncoder()

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 31, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@laf laf merged commit 8f0f1ba into librenms:master Mar 31, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment