New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Moved dnos health disco to powerconnect #6331

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Apr 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Since moving some dnos to powerconnect I assumed that the powerconnect health info would work for these new devices but it doesn't as per the report on twitter.

I've moved the dnos health info over but left the reference to dnos in the discovery so that existing users who had health info will have historical data restored.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 3, 2017

Thank you for submitting a PR @laf! We have found the following @alangregory, @ahmedsajid and @murrant based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @alangregory, @ahmedsajid and @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 3, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@murrant murrant merged commit 8a2f103 into librenms:master Apr 4, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:twitter-dnos branch Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment