newdevice: Added detection fro Juniper MSS #6335

Merged
merged 2 commits into from Apr 6, 2017

Conversation

Projects
None yet
6 participants
@laf
Member

laf commented Apr 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #5672

@laf laf added the Device 🖥 label Apr 3, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 3, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @Rosiak and @geordish based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @murrant, @Rosiak and @geordish based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
includes/definitions/juniper-mss.yaml
+ - { graph: device_bits, text: 'Device Traffic' }
+discovery:
+ - sysObjectId:
+ - .1.3.6.1.4.1.14525.3.3.1

This comment has been minimized.

@murrant

murrant Apr 4, 2017

Member

Looking at the issue shouldn't the sysObjectId be .1.3.6.1.4.1.14525.3. ?

@murrant

murrant Apr 4, 2017

Member

Looking at the issue shouldn't the sysObjectId be .1.3.6.1.4.1.14525.3. ?

librenms-docs
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 5, 2017

Member

Updated. Well spotted.

Member

laf commented Apr 5, 2017

Updated. Well spotted.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 5, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@f0o

f0o approved these changes Apr 6, 2017

@laf laf merged commit 61bb58b into librenms:master Apr 6, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue-5672 branch Apr 6, 2017

murrant added a commit to murrant/librenms that referenced this pull request Apr 7, 2017

newdevice: Added detection fro Juniper MSS (#6335)
* newdevice: Added detection fro Juniper MSS

* update sysObjectId check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment