New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic support for Omnitron iConverters #6336

Merged
merged 2 commits into from Apr 4, 2017

Conversation

Projects
None yet
5 participants
@EnzoZafra
Contributor

EnzoZafra commented Apr 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes: #6329

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 3, 2017

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated includes/definitions/omnitron-iconverter.yaml
discovery:
- sysObjectId:
- .1.3.6.1.4.1.7342
- sysDescr_regex:

This comment has been minimized.

@murrant

murrant Apr 4, 2017

Member

Please remove sysDescr_regex.
What you have here is:
sysObjectId starts with .1.3.6.1.4.1.7342
OR
sysDescr matches this regex "..."

If you want
sysObjectId starts with .1.3.6.1.4.1.7342
AND
sysDescr contains iConverter
Use this:

discovery:
    -
        - sysObjectId: .1.3.6.1.4.1.7342
        - sysDescr: iConverter

But it looks like the vendor has properly utilized sysObjectId, so you can just use:

discovery:
    - sysObjectId:
        - .1.3.6.1.4.1.7342.5.
@murrant

murrant Apr 4, 2017

Member

Please remove sysDescr_regex.
What you have here is:
sysObjectId starts with .1.3.6.1.4.1.7342
OR
sysDescr matches this regex "..."

If you want
sysObjectId starts with .1.3.6.1.4.1.7342
AND
sysDescr contains iConverter
Use this:

discovery:
    -
        - sysObjectId: .1.3.6.1.4.1.7342
        - sysDescr: iConverter

But it looks like the vendor has properly utilized sysObjectId, so you can just use:

discovery:
    - sysObjectId:
        - .1.3.6.1.4.1.7342.5.
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 4, 2017

Member

Can you please crop the logo png?

And fix the discovery issue I mentioned. After that, this is good to merge.

Member

murrant commented Apr 4, 2017

Can you please crop the logo png?

And fix the discovery issue I mentioned. After that, this is good to merge.

@EnzoZafra

This comment has been minimized.

Show comment
Hide comment
@EnzoZafra

EnzoZafra Apr 4, 2017

Contributor

Done. Sorry, new to this.

Contributor

EnzoZafra commented Apr 4, 2017

Done. Sorry, new to this.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 4, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 4, 2017

Member

No worries, looks good overall, just a few items.
Documentation on the yaml discovery isn't the clearest.

Member

murrant commented Apr 4, 2017

No worries, looks good overall, just a few items.
Documentation on the yaml discovery isn't the clearest.

@murrant murrant merged commit 9b62ea2 into librenms:master Apr 4, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EnzoZafra EnzoZafra deleted the EnzoZafra:issue-6329 branch Apr 13, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.