New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix whitespace display on RRDTool Command #6345

Merged
merged 2 commits into from Apr 5, 2017

Conversation

Projects
None yet
6 participants
@tsumaru720
Contributor

tsumaru720 commented Apr 4, 2017

edit update images*

The RRDTool command section removes extra white-space which is used in formatting

See example images

rrd-old
rrd-new

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 4, 2017

Thank you for submitting a PR @tsumaru720! We have found the following @paulgear, @laf and @murrant based on the history of these files to review this PR.

mention-bot commented Apr 4, 2017

Thank you for submitting a PR @tsumaru720! We have found the following @paulgear, @laf and @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 4, 2017

Auto-Deploy finished, Test PR at http://6345.ci.librenms.org or https://6345.ci.librenms.org

Show outdated Hide outdated html/css/styles.css
@@ -838,6 +838,13 @@ a.interface-upup:hover, a.interface-updown:hover, a.interface-admindown:hover {
margin: 8px;
}
.infobox pre {

This comment has been minimized.

@murrant

murrant Apr 4, 2017

Member

This css selector is a little generic. I'd prefer you make it more specific (with a class for example) or just put the style in the html code.

@murrant

murrant Apr 4, 2017

Member

This css selector is a little generic. I'd prefer you make it more specific (with a class for example) or just put the style in the html code.

This comment has been minimized.

@tsumaru720

tsumaru720 Apr 4, 2017

Contributor

will make it a new class - i did it this way so the bg colour is the same as infobox so if im specifying the colour, i feel it should be with the rest of the CSS instead of hidden away in code somewhere

new change coming shortly

@tsumaru720

tsumaru720 Apr 4, 2017

Contributor

will make it a new class - i did it this way so the bg colour is the same as infobox so if im specifying the colour, i feel it should be with the rest of the CSS instead of hidden away in code somewhere

new change coming shortly

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 4, 2017

Auto-Deploy finished, Test PR at http://6345.ci.librenms.org or https://6345.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 4, 2017

The inspection completed: No new issues

@tsumaru720

This comment has been minimized.

Show comment
Hide comment
@tsumaru720

tsumaru720 Apr 4, 2017

Contributor

hows that @murrant ?

Contributor

tsumaru720 commented Apr 4, 2017

hows that @murrant ?

@murrant

murrant approved these changes Apr 5, 2017

@laf laf merged commit 18784fd into librenms:master Apr 5, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tsumaru720 tsumaru720 deleted the tsumaru720:rrd-pre branch Apr 25, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.