Add OS Polling for Opengear ACM7008 #6349

Merged
merged 3 commits into from Apr 5, 2017

Conversation

Projects
None yet
5 participants
@EnzoZafra
Contributor

EnzoZafra commented Apr 4, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 4, 2017

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@EnzoZafra EnzoZafra referenced this pull request Apr 4, 2017

Closed

OS Polling for Opengear devices #6348

5 of 5 tasks complete
includes/polling/os/opengear.inc.php
+//
+$ogFirmwareVersion = snmp_get($device, '1.3.6.1.4.1.25049.17.1.1', '-OQv', '', '');
+$ogFirmwareVersion = explode(' ', $ogFirmwareVersion);
+$version = 'v' . trim($ogFirmwareVersion[0], '" ');

This comment has been minimized.

@laf

laf Apr 5, 2017

Member

Do we need to prepend the v here? We don't do that elsewhere and I think it's better to leave it as shown from the device.

@laf

laf Apr 5, 2017

Member

Do we need to prepend the v here? We don't do that elsewhere and I think it's better to leave it as shown from the device.

This comment has been minimized.

@EnzoZafra

EnzoZafra Apr 5, 2017

Contributor

Done, also removed (... ,'', '') in the snmp_get calls

@EnzoZafra

EnzoZafra Apr 5, 2017

Contributor

Done, also removed (... ,'', '') in the snmp_get calls

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 5, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit 699e99e into librenms:master Apr 5, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

murrant added a commit to murrant/librenms that referenced this pull request Apr 7, 2017

newdevice: Updated OS Polling for Opengear ACM7008 (#6349)
* Add OS Polling for Opengear ACM7008

* Fixed OSDiscoveryTest.php whitespaces

* Removed 'v' from OS version polling

@EnzoZafra EnzoZafra deleted the EnzoZafra:issue-6348 branch Apr 13, 2017

@librenms librenms locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.