New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Device Support - ICT DC Distribution Panel #6379

Merged
merged 5 commits into from Apr 12, 2017

Conversation

Projects
None yet
5 participants
@EnzoZafra
Contributor

EnzoZafra commented Apr 7, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

  • Supports current, voltage and fuse state sensors
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 7, 2017

Thank you for submitting a PR @EnzoZafra! We have found the following @murrant, @laf and @Rosiak based on the history of these files to review this PR.

Thank you for submitting a PR @EnzoZafra! We have found the following @murrant, @laf and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@EnzoZafra EnzoZafra closed this Apr 7, 2017

@EnzoZafra EnzoZafra reopened this Apr 7, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@EnzoZafra EnzoZafra closed this Apr 7, 2017

@EnzoZafra EnzoZafra reopened this Apr 7, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant approved these changes Apr 8, 2017

Looks good to me.

I assume you tested against the actual hardware?

@EnzoZafra

This comment has been minimized.

Show comment
Hide comment
@EnzoZafra

EnzoZafra Apr 9, 2017

Contributor

Yep, checked and its good!

Contributor

EnzoZafra commented Apr 9, 2017

Yep, checked and its good!

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 12, 2017

The inspection completed: 1 new issues, 2 updated code elements

The inspection completed: 1 new issues, 2 updated code elements

@murrant murrant merged commit 457f2e9 into librenms:master Apr 12, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 12, 2017

Member

👍

Member

murrant commented Apr 12, 2017

👍

@EnzoZafra EnzoZafra referenced this pull request Apr 13, 2017

Closed

New Device Support - ICT DC Distribution Panel #6374

5 of 5 tasks complete

@EnzoZafra EnzoZafra deleted the EnzoZafra:issue-6374 branch Apr 13, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.