New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added rrdtool version check to compare installed version with defined version #6381

Merged
merged 2 commits into from Apr 10, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Apr 7, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Came across a user this week who had blindly set $config['rrdtool_version'] = '1.6.0'; when running 1.4.3 resulting in poor performance apparently. Easy enough to test for.

librenms-docs
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 7, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @khobbits and @geordish based on the history of these files to review this PR.

mention-bot commented Apr 7, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @khobbits and @geordish based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 7, 2017

Auto-Deploy finished, Test PR at http://6381.ci.librenms.org or https://6381.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 8, 2017

Member

The inverse is fine though, having a lower version defined than installed. This effectively limits the features rrdtool can use (falls back to is_file() checks)

Member

murrant commented Apr 8, 2017

The inverse is fine though, having a lower version defined than installed. This effectively limits the features rrdtool can use (falls back to is_file() checks)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 8, 2017

Member

What benefit does that give the user? Imho users should set the version they use, it took ages to work out last time the version mismatch was the cause.

The better solution is to remove that variable and auto detect the version.

Member

laf commented Apr 8, 2017

What benefit does that give the user? Imho users should set the version they use, it took ages to work out last time the version mismatch was the cause.

The better solution is to remove that variable and auto detect the version.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 8, 2017

Member

Perhaps, what is your rrdtool version and the variable on your main setup?

Member

murrant commented Apr 8, 2017

Perhaps, what is your rrdtool version and the variable on your main setup?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 8, 2017

Member

I don't specify it, on my dev, home and work installs it's left to just use the binary.

Member

laf commented Apr 8, 2017

I don't specify it, on my dev, home and work installs it's left to just use the binary.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 10, 2017

Member

I think for validate we should only raise the alarm if the version is newer than the binary

Member

murrant commented Apr 10, 2017

I think for validate we should only raise the alarm if the version is newer than the binary

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 10, 2017

Auto-Deploy finished, Test PR at http://6381.ci.librenms.org or https://6381.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 10, 2017

The inspection completed: No new issues

@murrant murrant merged commit 5ce9b6b into librenms:master Apr 10, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:validate-rrdtool-ver branch Apr 10, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.