New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: detect more devices as Comware #6386

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Apr 8, 2017

Only some H3C Comware devices were detected as comware, detect them all.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

newdevice: improve comware detection
Only some H3C Comware devices were detected as comware, detect them all.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 8, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @FTBZ based on the history of these files to review this PR.

Thank you for submitting a PR @murrant! We have found the following @laf, @Rosiak and @FTBZ based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 8, 2017

The inspection completed: No new issues

The inspection completed: No new issues

Update the test data
FYI, C1234 was just a nonsense string
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 8, 2017

Member

Some accidental merges in there, but they only reformat things (was doing that so I could read them).
Let me know if you want me to remove them.

Member

murrant commented Apr 8, 2017

Some accidental merges in there, but they only reformat things (was doing that so I could read them).
Let me know if you want me to remove them.

@laf laf merged commit e005f78 into librenms:master Apr 13, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:comware-detect branch Apr 13, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.