New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Eaton/MGE UPS reorganization #6388

Merged
merged 4 commits into from Apr 24, 2017

Conversation

Projects
None yet
6 participants
@murrant
Member

murrant commented Apr 10, 2017

MGE split Galaxy (and Upsilon) to apc-mgeups
All others to eaton-mgeups
Remove mge ups from eatonups os.
Remove powerware it is a duplicate of eatonups

Not ready for commit! No changes to sensor discovery/polling, other than powerware removal.
I need feed back to know if I have categorized these UPS correctly.

mgepdu.snmprec and mgeups-galaxy.snmprec are updated from user stats. The rest are guessed.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 10, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@murrant murrant removed the Blocker 🚫 label Apr 15, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 15, 2017

Member

Replaces #6279 and #6267

Member

murrant commented Apr 15, 2017

Replaces #6279 and #6267

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@murrant murrant changed the title from newdevice: Eaton/MGE UPS cleanup to newdevice: Eaton/MGE UPS reorganization Apr 15, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 17, 2017

Member

Needs a notification for users explaining the OS changes + loss in data.

Member

laf commented Apr 17, 2017

Needs a notification for users explaining the OS changes + loss in data.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 18, 2017

Member

@FTBZ and anyone else, does this look ok?

If it does I'll post a notification so we can merge it.

Member

murrant commented Apr 18, 2017

@FTBZ and anyone else, does this look ok?

If it does I'll post a notification so we can merge it.

murrant added some commits Apr 8, 2017

newdevice: Eaton/MGE UPS cleanup
MGE split Galaxy (and Upsilon) to apc-mgeups
All others to eaton-mgeups
Remove mge ups from eatonups os.
Remove powerware it is a duplicate of eatonups
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 19, 2017

The inspection completed: 2 updated code elements

The inspection completed: 2 updated code elements

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Apr 19, 2017

Contributor

Just to be sure, it's replacing #6279? (sorry I was off a few days for Easter holidays)

Contributor

FTBZ commented Apr 19, 2017

Just to be sure, it's replacing #6279? (sorry I was off a few days for Easter holidays)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 19, 2017

Member

I believe that's correct.

Member

laf commented Apr 19, 2017

I believe that's correct.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 19, 2017

Member

Yes, I've covered the changes from #6279 and #6267, so they can be closed.

Member

murrant commented Apr 19, 2017

Yes, I've covered the changes from #6279 and #6267, so they can be closed.

@laf laf merged commit 43914fb into librenms:master Apr 24, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is not signed yet.
Details

@murrant murrant deleted the murrant:eaton-cleanup branch May 10, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.