New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Video' device group and moved Axis cameras to this group' #6397

Merged
merged 3 commits into from Apr 17, 2017

Conversation

Projects
None yet
5 participants
@EnzoZafra
Contributor

EnzoZafra commented Apr 11, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 11, 2017

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @adaniels21487 and @pheinrichs based on the history of these files to review this PR.

Thank you for submitting a PR @EnzoZafra! We have found the following @laf, @adaniels21487 and @pheinrichs based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 11, 2017

Member

I'm not a fan of video, from the sysDescr this could be a variety of things so appliance may be a better fit but overall I'm not sure we should change it.

Member

laf commented Apr 11, 2017

I'm not a fan of video, from the sysDescr this could be a variety of things so appliance may be a better fit but overall I'm not sure we should change it.

@EnzoZafra

This comment has been minimized.

Show comment
Hide comment
@EnzoZafra

EnzoZafra Apr 11, 2017

Contributor

@laf Is it possible to at least move the network cameras to a separate group? Something like 'Surveillance' or 'Cameras'? The video encoders and video servers could stay in the 'Network' group.

Contributor

EnzoZafra commented Apr 11, 2017

@laf Is it possible to at least move the network cameras to a separate group? Something like 'Surveillance' or 'Cameras'? The video encoders and video servers could stay in the 'Network' group.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 12, 2017

Member

That would mean splitting out this OS discovery into 3 separate OS'.

You are more than welcome to submit a pull request to do this but my opinion (not the projects) is that this should be kept simple - basically as it is with the appropriate type, appliance potentially fits better here.

Member

laf commented Apr 12, 2017

That would mean splitting out this OS discovery into 3 separate OS'.

You are more than welcome to submit a pull request to do this but my opinion (not the projects) is that this should be kept simple - basically as it is with the appropriate type, appliance potentially fits better here.

@EnzoZafra

This comment has been minimized.

Show comment
Hide comment
@EnzoZafra

EnzoZafra Apr 12, 2017

Contributor

Okay, that makes sense. The important part for us is to separate the Axis cameras from the network group as we have hundreds of cameras and the switches are getting pushed back to the last few pages - so this will solve our problem

Contributor

EnzoZafra commented Apr 12, 2017

Okay, that makes sense. The important part for us is to separate the Axis cameras from the network group as we have hundreds of cameras and the switches are getting pushed back to the last few pages - so this will solve our problem

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 13, 2017

Member

Needs a rebase and also a notification adding:

https://github.com/librenms/librenms.github.io/blob/master/notifications.rss

Use 'Change to Cisco UCM type from tele to collaboration' as an example, needs to give around 4 days notice.

Member

laf commented Apr 13, 2017

Needs a rebase and also a notification adding:

https://github.com/librenms/librenms.github.io/blob/master/notifications.rss

Use 'Change to Cisco UCM type from tele to collaboration' as an example, needs to give around 4 days notice.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 13, 2017

The inspection completed: 2 updated code elements

The inspection completed: 2 updated code elements

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 13, 2017

Member

I've merged the notification.

This should be merged on the 17th.

Member

laf commented Apr 13, 2017

I've merged the notification.

This should be merged on the 17th.

@laf laf added the Blocker 🚫 label Apr 13, 2017

@laf laf merged commit 8c8a41f into librenms:master Apr 17, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EnzoZafra EnzoZafra deleted the EnzoZafra:issue-6396 branch Jun 14, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.