New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow unit tests without a sql server #6398

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Apr 11, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 11, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented Apr 11, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 11, 2017

Auto-Deploy finished, Test PR at http://6398.ci.librenms.org or https://6398.ci.librenms.org

Fix db connection in bootstrap.php
Mark tests as skipped
Make sure the sql queries in bootstrap.php have run
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Apr 11, 2017

Auto-Deploy finished, Test PR at http://6398.ci.librenms.org or https://6398.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 11, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Apr 11, 2017

The inspection completed: 2 updated code elements

@laf laf merged commit 06add77 into librenms:master Apr 13, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@murrant murrant deleted the murrant:test-no-sql branch Apr 13, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.