New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unecessary OS checks in proc / mem polling #6414

Merged
merged 1 commit into from Apr 15, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Apr 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

For mem and proc polling, we decide which files to load by the entries in the DB so checking again then the OS is pointless. I was led to this by https://community.librenms.org/t/processor-usage-at-0-with-dell-powerconnect-dnos-cpu/1007/2 due to the dnos change recently.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 13, 2017

Thank you for submitting a PR @laf! We have found the following @vitalisator, @murrant and @NerdBlender based on the history of these files to review this PR.

Thank you for submitting a PR @laf! We have found the following @vitalisator, @murrant and @NerdBlender based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 13, 2017

The inspection completed: 2 updated code elements

The inspection completed: 2 updated code elements

@murrant murrant merged commit 7f83148 into librenms:master Apr 15, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:fix/mem-proc-polling branch Apr 15, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.