New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create check_mssql_health.inc.php #6415

Merged
merged 1 commit into from Apr 17, 2017

Conversation

Projects
None yet
5 participants
@premtimibrahimi
Contributor

premtimibrahimi commented Apr 13, 2017

This could be very usefull for the people who want to monitor MS SQL Servers. It is a very cool service check.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Create check_mssql_health.inc.php
This could be very usefull for the people who want to monitor MS SQL Servers. It is a very cool service check.
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 13, 2017

Auto-Deploy finished, Test PR at http://6415.ci.librenms.org or https://6415.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 13, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Apr 13, 2017

The inspection completed: 2 updated code elements

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 15, 2017

Member

check_mssql_health does not seem to be in the standard nagios/monitoring plugins. @librenms/reviewers How should we deal with that? Check for it's existence before listing? Add an note?

Member

murrant commented Apr 15, 2017

check_mssql_health does not seem to be in the standard nagios/monitoring plugins. @librenms/reviewers How should we deal with that? Check for it's existence before listing? Add an note?

@premtimibrahimi

This comment has been minimized.

Show comment
Hide comment
@premtimibrahimi

premtimibrahimi Apr 15, 2017

Contributor

Honestly not sure, but integrating it within librenms would be a good idea. To make this service check work its simple.

Contributor

premtimibrahimi commented Apr 15, 2017

Honestly not sure, but integrating it within librenms would be a good idea. To make this service check work its simple.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 17, 2017

Member

@murrant The list of nagios checks is pulled from the plugin dir for the user so if you add any check_* file it will be listed so this is fine as it's only used when someone selects it.

Member

laf commented Apr 17, 2017

@murrant The list of nagios checks is pulled from the plugin dir for the user so if you add any check_* file it will be listed so this is fine as it's only used when someone selects it.

@laf laf merged commit 09e9fe6 into librenms:master Apr 17, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Apr 18, 2017

Member

Oh great! Didn't even look at the code 😊

Member

murrant commented Apr 18, 2017

Oh great! Didn't even look at the code 😊

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.