New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added detection and sensor support for EMC OneFS v8 #6416

Merged
merged 2 commits into from Apr 15, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Apr 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6412

Also adds various sensors and storage support.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@laf laf added the Device 🖥 label Apr 13, 2017

Show outdated Hide outdated includes/definitions/onefs.yaml
@@ -10,3 +12,5 @@ over:
discovery:
- sysObjectId:
- .1.3.6.1.4.1.12124.1
- sysDescr_regex:

This comment has been minimized.

@murrant

murrant Apr 15, 2017

Member

Two questions: why include the ' v8'? and why _regex what you have here is the same as a normal sysDescr

@murrant

murrant Apr 15, 2017

Member

Two questions: why include the ' v8'? and why _regex what you have here is the same as a normal sysDescr

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 15, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@murrant murrant merged commit d0c8740 into librenms:master Apr 15, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue/6412 branch Apr 15, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.