New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengridscheduler job tracker #6419

Merged
merged 5 commits into from Apr 24, 2017

Conversation

Projects
None yet
5 participants
@svennd
Contributor

svennd commented Apr 14, 2017

I created a script to track Open Grid Scheduler (http://gridscheduler.sourceforge.net) which is integrated in Rocks (http://www.rocksclusters.org) this simply tracks the amount of jobs (pending, running, zombie, suspended)

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 14, 2017

Thank you for submitting a PR @svennd! We have found the following @murrant, @laf and @crcro based on the history of these files to review this PR.

mention-bot commented Apr 14, 2017

Thank you for submitting a PR @svennd! We have found the following @murrant, @laf and @crcro based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 14, 2017

Auto-Deploy finished, Test PR at http://6419.ci.librenms.org or https://6419.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 14, 2017

Auto-Deploy finished, Test PR at http://6419.ci.librenms.org or https://6419.ci.librenms.org

@svennd svennd referenced this pull request Apr 16, 2017

Closed

agree to contributor agreement #6437

2 of 2 tasks complete
Show outdated Hide outdated html/includes/graphs/application/opengridscheduler_ogs.inc.php
$printtotal = 0;
$addarea = 1;
$transparency = 33;
$rrd_filename = $config['rrd_dir'].'/'.$device['hostname'].'/app-ogs-'.$app['app_id'].'.rrd';

This comment has been minimized.

@laf

laf Apr 17, 2017

Member

You need to build $rrd_filename using rrd_name()

@laf

laf Apr 17, 2017

Member

You need to build $rrd_filename using rrd_name()

Show outdated Hide outdated html/includes/graphs/application/opengridscheduler_ogs.inc.php
$i = 0;
if (is_file($rrd_filename)) {

This comment has been minimized.

@laf

laf Apr 17, 2017

Member

Don't use is_file() and use rrdtool_check_rrd_exists() instead

@laf

laf Apr 17, 2017

Member

Don't use is_file() and use rrdtool_check_rrd_exists() instead

Show outdated Hide outdated includes/polling/applications/opengridscheduler.inc.php
echo ' ' . $name;
// get data through snmp
$ogs_data = snmp_walk($device, $oid, '-Oqv', 'NET-SNMP-EXTEND-MIB');

This comment has been minimized.

@laf

laf Apr 17, 2017

Member

You can drop , 'NET-SNMP-EXTEND-MIB' as it's not needed when using numeric OID

@laf

laf Apr 17, 2017

Member

You can drop , 'NET-SNMP-EXTEND-MIB' as it's not needed when using numeric OID

Show outdated Hide outdated scripts/agent-local/rocks.sh
@@ -0,0 +1,20 @@
#!/bin/bash

This comment has been minimized.

@laf

laf Apr 17, 2017

Member

This whole file needs to go to: https://github.com/librenms/librenms-agent/pulls

@laf
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 17, 2017

Member

Few things need updating in this before we can merge, great effort though :)

Member

laf commented Apr 17, 2017

Few things need updating in this before we can merge, great effort though :)

svennd and others added some commits Apr 18, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 18, 2017

The inspection completed: 230 new issues

scrutinizer-notifier commented Apr 18, 2017

The inspection completed: 230 new issues

@laf laf merged commit b2e6d8a into librenms:master Apr 24, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is not signed yet.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.