New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated enterasys proc discovery by setting correct index #6422

Merged
merged 1 commit into from Apr 15, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Apr 14, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6225

$index was set to 0 for all procs.

This does mean that the cpu graphs may jump as I think the 1st cpu will now become what was the 3rd cpu but I don't see a fix unless we count down instead of up but that limits the # of cpus.

@laf laf added the Bug 🐞 label Apr 14, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 14, 2017

Auto-Deploy finished, Test PR at http://6422.ci.librenms.org or https://6422.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 14, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Apr 14, 2017

The inspection completed: 2 updated code elements

@murrant murrant merged commit 78c77ac into librenms:master Apr 15, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:issue/6225 branch Apr 15, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.